Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for "How it works" #23

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Docs for "How it works" #23

merged 1 commit into from
Jun 4, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented May 29, 2019

New page explaining what events the extension is subscribed to and what they do when the event is triggered.

@humitos humitos requested a review from a team May 29, 2019 14:11
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be helpful to link to the sphinx docs of these events.

Events subscribed
-----------------

There are 3 main events that this extension subscribes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are 3 main events that this extension subscribes,
There are 3 main events that this extension subscribes:

@humitos humitos merged commit 3be1bc2 into master Jun 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the humitos/how-it-works-docs branch June 4, 2019 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants