Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroducing the mail module? #45

Open
schmitzhermes opened this issue Nov 14, 2018 · 2 comments
Open

Reintroducing the mail module? #45

schmitzhermes opened this issue Nov 14, 2018 · 2 comments

Comments

@schmitzhermes
Copy link

Hey folks,

the mail module was deprecated a while ago due to the use java.awt.* classes. I managed based on some stackoverflow posts and external dependencies (android-mail) to make the mail module working on android. I know there is already a PR open (#20), but it seems it's out of date and it's diff is way too huge.
Is anyone interested in a working implementation of mail on the android platform?

@codewrangler1
Copy link

If you have a way to make the current SMIME from SC work/build, please post it.

I'm trying use the updated SMIME code, to see if it fixes an issue I'm having, but can't build it because of the AWT dependencies.

Thanks!

Michael

@Skywalker-11
Copy link

Most changes in that PR come by renaming package names etc. (same way the normal spongycastle package is adjusted). This is done by the become-spongy.sh (if I remember correctly basically search/replace). If you follow the mkspongymail.README from the PR this covers nearly all of the changes.
Then apply additional patches from the PR: https://github.com/Skywalker-11/spongycastle/compare/1094f253423ccf111562b10e30acfa4d105a3958...Skywalker-11:spongy-master?expand=1

The PR is based on r1v54 of BC.

I think AWT was only used in desktop applications as gui parts and not needed for android. You can just remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants