Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring extraction when key === value #103

Open
intellix opened this issue Jul 30, 2015 · 4 comments
Open

Ignoring extraction when key === value #103

intellix opened this issue Jul 30, 2015 · 4 comments

Comments

@intellix
Copy link

Our translators seem to have a thing for translating English to English even if they change nothing (maybe they like 100% completion in their tool of choice?).

After extraction, we have something like:

{
    "en-GB": {
        "Home": "Home",
        "Account": "Account",
        "Support": "Support"
    }
}

We could slap the translators and tell them to remove them all, but think a few would still slip by. I think it'd be great if extraction just did a key===value check and ignored the entry in such a case.

@rubenv
Copy link
Owner

rubenv commented Jul 30, 2015

I'm not entirely sure what it is that you are proposing.

Extraction doesn't know anything about translated strings.

Care to shed some light on this?

@intellix
Copy link
Author

Apologies for saying extraction. I meant compilation :) when the PO is processed and the JSON is created. Would be good to skip entries where key === value

@rubenv
Copy link
Owner

rubenv commented Jul 31, 2015

Oh, right!

Makes sense. One minor thing: this would conflict with the (admittedly rather useless) debug mode.

@alfaproject
Copy link

How come it would conflict? o:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants