Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby 2.3+ and drop Ruby 2.2 support #975

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

eregon
Copy link
Collaborator

@eregon eregon commented Dec 21, 2022

  • Set required_ruby_version to 2.3.
  • rb_data_object_alloc() is deprecated since a long time by rb_data_object_wrap() but that is not available in Ruby 2.2, so drop Ruby 2.2 support.

Example failed CI run on 2.2:
https://github.com/ruby-concurrency/concurrent-ruby/actions/runs/3749315062/jobs/6367656392

compiling ../../../../ext/concurrent-ruby-ext/atomic_reference.c
../../../../ext/concurrent-ruby-ext/atomic_reference.c: In function ‘ir_alloc’:
../../../../ext/concurrent-ruby-ext/atomic_reference.c:47:10: warning: implicit declaration of function ‘rb_data_object_wrap’; did you mean ‘rb_data_object_get’? [-Wimplicit-function-declaration]
   47 |   return rb_data_object_wrap(klass, (void *) Qnil, ir_mark, NULL);
      |          ^~~~~~~~~~~~~~~~~~~
      |          rb_data_object_get

@eregon eregon changed the title Require Ruby 2.3+ and drop Ruby 2.2. support Require Ruby 2.3+ and drop Ruby 2.2 support Dec 21, 2022
* Set `required_ruby_version` to 2.3.
* `rb_data_object_alloc()` is deprecated since a long time
  by `rb_data_object_wrap()` but that is not available in Ruby 2.2,
  so drop Ruby 2.2 support.
@eregon
Copy link
Collaborator Author

eregon commented Dec 21, 2022

Bundler 2 also needs Ruby 2.3+ so this also simplifies the experience for local development (also 2.2 is quite messy to install).

@eregon eregon merged commit 506302a into ruby-concurrency:master Dec 21, 2022
@eregon eregon deleted the require-2.3 branch December 21, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant