Regression with leading zero keys

[oleksii-leonov]

What I tried to do

With next localization keys:

en:
  test_data:
    '000': 'Value 000'
    '001': 'Value 001'
    '002': 'Value 002'
    '111': 'Value 111'

I18n version 1.1.1 it works fine:

> I18n.t('test_data.001')
=> "Value 001"

I18n version 1.4.0 didn't work:

> I18n.t('test_data.001')
=> "translation missing: en.test_data.1"

What I expected to happen

Behavior should be consistent with version 1.1.1.

What actually happened

Behavior changed.

Versions of i18n, rails, and anything else you think is necessary

Changes was introduced in 38732a6

i18n/lib/i18n.rb

Line 368 in 38732a6

k.to_i

---

I believe, i18n should't try convert keys to number if key starts with 0.

So, regexp:

i18n/lib/i18n.rb

Line 367 in 38732a6

when /\A[-+]?\d+\z/ # integer

should be changed with: \A[-+]?[1-9]\d*\z.

This way strings like 12345 would be converted to numbers, but strings like 0001 stay untouched.

[radar]

Thanks for letting us know about it. It seems like you know the solution already. Please submit a PR to fix it.

[oleksii-leonov]

@radar
Done in #457.