Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build updates #558

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Build updates #558

merged 3 commits into from
Feb 11, 2021

Conversation

carlosantoniodasilva
Copy link
Member

@carlosantoniodasilva carlosantoniodasilva commented Feb 6, 2021 •
edited
Loading

  • Rails main now targets version 7.0, and with that it supports Ruby 2.7+ only
  • Exclude Ruby 3 + Rails 5.x from test matrix (it appears 5.0 & 5.1 were passing there, but Ruby 3 is not officially supported there anyway and 5.2 was already excluded, so I thought it'd make sense to just not support Ruby 3 on Rails < 6 officially)
  • Run tests on the latest patch versions of each Ruby release

@carlosantoniodasilva
Run tests on the latest patch version of each Ruby release
2a02807
@carlosantoniodasilva
Rails main only supports Ruby 2.7+ going forward
075a228 
Rails is now targetting version 7.0, and with that it dropped support
for Ruby < 2.7.

rails/rails@6487836
rails/rails@1b455e2
@carlosantoniodasilva
Exclude Ruby 3+ with all Rails 5.x versions
bb7b689 
These were passing with Rails 5.0 & 5.1 gemfiles, but were already
excluded with Rails 5.2. Given Rails only officially supports Ruby 3
with Rails 6+, we don't need to test/support it with 5.x versions.
@carlosantoniodasilva carlosantoniodasilva self-assigned this Feb 6, 2021
@carlosantoniodasilva carlosantoniodasilva marked this pull request as ready for review February 6, 2021 12:04
@carlosantoniodasilva carlosantoniodasilva mentioned this pull request Feb 6, 2021
Merged
@radar
Copy link
Collaborator

radar commented Feb 11, 2021

Seems legit to me :)

@radar radar merged commit 7a262de into master Feb 11, 2021
@radar radar deleted the ca-build branch February 11, 2021 02:47
This was referenced Mar 11, 2021
Closed
Merged
Closed
Closed
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carlosantoniodasilva carlosantoniodasilva

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosantoniodasilva @radar