Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Does i18n use Semver? #632

Closed
ebouchut opened this issue Jul 13, 2022 · 3 comments
Closed

[QUESTION] Does i18n use Semver? #632

ebouchut opened this issue Jul 13, 2022 · 3 comments

Comments

@ebouchut
Copy link

ebouchut commented Jul 13, 2022

I may be wrong but it seems to me that i18n does not support Semantic Versioning as version 1.11.0 (a minor version) introduced what looks to me as a breaking change where the zero (and one when count is not present) keys are no longer supported.

Clarifying this point in the README would help given the impact it may have on 3rd party gems.

Thanks,

@radar
Copy link
Collaborator

radar commented Jul 13, 2022

Yes it does.

the change appeared to me to be just for CLDR. If it’s breaking other things, then please do file an issue about that breakage (following the issue guide) so that we can fix it.

Thanks!

@radar radar closed this as completed Jul 13, 2022
@radar
Copy link
Collaborator

radar commented Jul 13, 2022

I’ve just started my day (read: I’m still in bed) and read the other thread. Once I’m at work today, I’ll look at how we can fix this proper.

@ebouchut
Copy link
Author

Thank you @radar for quickly releasing a new minor version that rolled back the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants