From 2a0280712f62e9e2399eaa1c93be3a9755fb7b0e Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Sat, 6 Feb 2021 08:52:27 -0300 Subject: [PATCH 1/3] Run tests on the latest patch version of each Ruby release --- .github/workflows/ruby.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index b0741ac1..600d75b3 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -15,7 +15,7 @@ jobs: strategy: fail-fast: false matrix: - ruby_version: [3.0.0, 2.7.1, 2.6.5, 2.5.7, 2.4.9, 2.3.8, jruby] + ruby_version: [3.0, 2.7, 2.6, 2.5, 2.4, 2.3, jruby] gemfile: [ Gemfile, @@ -28,25 +28,25 @@ jobs: ] exclude: # Ruby 3.x is not supported by Rails 5.2.x - - ruby_version: 3.0.0 + - ruby_version: 3.0 gemfile: gemfiles/Gemfile.rails-5.2.x # Ruby 2.4.x is not supported by Rails main - - ruby_version: 2.4.9 + - ruby_version: 2.4 gemfile: gemfiles/Gemfile.rails-main # Ruby 2.4.x is not supported by Rails 6.1.x - - ruby_version: 2.4.9 + - ruby_version: 2.4 gemfile: gemfiles/Gemfile.rails-6.1.x # Ruby 2.4.x is not supported by Rails 6.0.x - - ruby_version: 2.4.9 + - ruby_version: 2.4 gemfile: gemfiles/Gemfile.rails-6.0.x # Ruby 2.3.x is not supported by Rails 6.1.x - - ruby_version: 2.3.8 + - ruby_version: 2.3 gemfile: gemfiles/Gemfile.rails-6.1.x # Ruby 2.3.x is not supported by Rails main - - ruby_version: 2.3.8 + - ruby_version: 2.3 gemfile: gemfiles/Gemfile.rails-main # Ruby 2.3.x is not supported by Rails 6.0.x - - ruby_version: 2.3.8 + - ruby_version: 2.3 gemfile: gemfiles/Gemfile.rails-6.0.x # JRuby is not supported by Rails main - ruby_version: jruby From 075a22820e1ab8589128c3d1378c3a136c051171 Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Sat, 6 Feb 2021 08:53:26 -0300 Subject: [PATCH 2/3] Rails main only supports Ruby 2.7+ going forward Rails is now targetting version 7.0, and with that it dropped support for Ruby < 2.7. https://github.com/rails/rails/commit/6487836af8f50648a9b30ce61864c827132e5592 https://github.com/rails/rails/commit/1b455e2e9d6937d4107e19cb32e2f98aa08886b9 --- .github/workflows/ruby.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index 600d75b3..b2983d53 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -30,6 +30,12 @@ jobs: # Ruby 3.x is not supported by Rails 5.2.x - ruby_version: 3.0 gemfile: gemfiles/Gemfile.rails-5.2.x + # Ruby 2.6.x is not supported by Rails main + - ruby_version: 2.6 + gemfile: gemfiles/Gemfile.rails-main + # Ruby 2.5.x is not supported by Rails main + - ruby_version: 2.5 + gemfile: gemfiles/Gemfile.rails-main # Ruby 2.4.x is not supported by Rails main - ruby_version: 2.4 gemfile: gemfiles/Gemfile.rails-main From bb7b689212a01baec405cc5f027ac4fc6b16fa71 Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Sat, 6 Feb 2021 08:56:21 -0300 Subject: [PATCH 3/3] Exclude Ruby 3+ with all Rails 5.x versions These were passing with Rails 5.0 & 5.1 gemfiles, but were already excluded with Rails 5.2. Given Rails only officially supports Ruby 3 with Rails 6+, we don't need to test/support it with 5.x versions. --- .github/workflows/ruby.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index b2983d53..6f67ad06 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -30,6 +30,12 @@ jobs: # Ruby 3.x is not supported by Rails 5.2.x - ruby_version: 3.0 gemfile: gemfiles/Gemfile.rails-5.2.x + # Ruby 3.x is not supported by Rails 5.1.x + - ruby_version: 3.0 + gemfile: gemfiles/Gemfile.rails-5.1.x + # Ruby 3.x is not supported by Rails 5.0.x + - ruby_version: 3.0 + gemfile: gemfiles/Gemfile.rails-5.0.x # Ruby 2.6.x is not supported by Rails main - ruby_version: 2.6 gemfile: gemfiles/Gemfile.rails-main