Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add racc to gemspec #680

Closed
wants to merge 2 commits into from
Closed

Add racc to gemspec #680

wants to merge 2 commits into from

Conversation

yykamei
Copy link

@yykamei yykamei commented Jan 23, 2024

According the release note of Ruby 3.3, racc will become the bundled gem. This patch adds the gem to i18n.gemspec for the next version of Ruby.

In addition to this change, I made changes in the GitHub workflow to run tests in Ruby 3.3 because I got an error in Ruby 3.3 when running tests: cannot load such file -- racc/parser. This error is resolved by adding racc to gemspec.

I want to make sure this Gem works in Ruby 3.3, so the GitHub workflow is also updated.

The backtrace for cannot load such file -- racc/parser

/Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require': cannot load such file -- racc/parser (LoadError)
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/yutaka.kamei/git/Fork/i18n/lib/i18n/gettext/po_parser.rb:13:in `<top (required)>'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/yutaka.kamei/git/Fork/i18n/lib/i18n/backend/gettext.rb:4:in `<top (required)>'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/yutaka.kamei/git/Fork/i18n/test/gettext/backend_test.rb:9:in `<class:Backend>'
	from /Users/yutaka.kamei/git/Fork/i18n/test/gettext/backend_test.rb:8:in `<class:I18nGettextBackendTest>'
	from /Users/yutaka.kamei/git/Fork/i18n/test/gettext/backend_test.rb:5:in `<top (required)>'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `block (2 levels) in replace_require'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:21:in `block in <main>'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:6:in `select'
	from /Users/yutaka.kamei/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/rake-13.1.0/lib/rake/rake_test_loader.rb:6:in `<main>'
rake aborted!

According the release note of Ruby 3.3, racc will become the bundled
gem. This patch adds the gem to i18n.gemspec for the next version of
Ruby.

In addition to this change, I made changes in the GitHub workflow to run
tests in Ruby 3.3 because I got an error in Ruby 3.3 when running tests:
`cannot load such file -- racc/parser`. This error is resolved by adding
racc to gemspec.

I want to make sure this Gem works in Ruby 3.3, so the GitHub workflow
is also updated.
@radar
Copy link
Collaborator

radar commented Mar 5, 2024

Thank you! I took this work into #684 and merged it in there.

@radar radar closed this Mar 5, 2024
@yykamei yykamei deleted the ruby-33 branch March 6, 2024 00:02
@yykamei
Copy link
Author

yykamei commented Mar 6, 2024

Thank you!

@stanhu
Copy link

stanhu commented Mar 6, 2024

FYI, this change broke our Ruby 3.1 CI builds because we were using ruby:3.1-slim, which does not have gcc and make. Our CI installs activesupport, which installs i18n. This change now pulls in racc, which has native extension support and thus requires a compiler.

Perhaps this should have been a major version bump.

@radar
Copy link
Collaborator

radar commented Mar 6, 2024

@stanhu This change has been reverted in I18n v1.14.4.

@stanhu
Copy link

stanhu commented Mar 6, 2024

@radar Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants