Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that escaped interpolations with reserved keywords raised ReservedInterpolationKey #688

Merged
merged 2 commits into from
May 6, 2024

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Mar 12, 2024

I found this issue when looking into fixing glebm/i18n-tasks#552. The reserved keywords in the interpolations were noticed due to #678. The proposed solution is to escape the interpolation with %% based on https://github.com/ruby-i18n/i18n/blob/master/lib/i18n/interpolate/ruby.rb.

However, the check for reserved keywords didn't care that the interpolation was escaped. I adjusted the regex for the reserved keywords with the same negative lookbehind assertion as proposed in the i18n-tasks issue.

@Bilka2
Copy link
Contributor Author

Bilka2 commented May 1, 2024

Hey, is there anything still to missing from my side to get this merged?

@radar
Copy link
Collaborator

radar commented May 6, 2024

Nothing from your side -- I've just been sick (flu hit me hard) and/or busy in the last little while! Back on deck now though.

@radar radar merged commit 2ab6eb0 into ruby-i18n:master May 6, 2024
@Bilka2 Bilka2 deleted the escaped-reserved-interpolation branch May 6, 2024 20:48
@Bilka2
Copy link
Contributor Author

Bilka2 commented May 6, 2024

Thank you for merging this and the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants