Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix trailing commas #256

Merged
merged 1 commit into from
Jan 13, 2016
Merged

fix trailing commas #256

merged 1 commit into from
Jan 13, 2016

Conversation

mynameisrufus
Copy link
Contributor

No description provided.

@jch
Copy link
Member

jch commented Jan 12, 2016

Could we add an exception for this rule? I actually prefer trailing commas in hashes because keeps diffs line oriented. http://mislav.net/2014/02/hidden-documentation/ explains:

Corollary of avoiding unrelated changes: stick to a line-based coding style that allows you to append, edit or remove values from lists without changing adjacent lines. Well, always think about the person who’s going to git blame this. In the JavaScript example, if you were the one who added a committed the value "baz", you don’t want your name to show up when somebody blames the line that added "bar", since the two variables might be unrelated.

@jch @mynameisrufus
fix trailing comma
9d62403 
Default is to require a trailing comma.
@mynameisrufus
Copy link
Contributor Author

Golang style. I can't disagree with this. PR updated with enforced commas.

@jch
Copy link
Member

jch commented Jan 13, 2016

Ha! Of course there's another rule that would enforce this. Thanks, merging.

jch added a commit that referenced this pull request Jan 13, 2016
@jch
Merge pull request #256 from mynameisrufus/rubocop-fix/trailing-comma
f1659c5 
fix trailing commas
@jch jch merged commit f1659c5 into ruby-ldap:master Jan 13, 2016
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Mar 16, 2016
Update ruby-net-ldap to 0.14.0.
509b0b6 
=== Net::LDAP 0.14.0

* Normalize the encryption parameter passed to the LDAP constructor {#264}[ruby-ldap/ruby-net-ldap#264]
* Update Docs: Net::LDAP now requires ruby >= 2 {#261}[ruby-ldap/ruby-net-ldap#261]
* fix symbol proc {#255}[ruby-ldap/ruby-net-ldap#255]
* fix trailing commas {#256}[ruby-ldap/ruby-net-ldap#256]
* fix deprecated hash methods {#254}[ruby-ldap/ruby-net-ldap#254]
* fix space after comma {#253}[ruby-ldap/ruby-net-ldap#253]
* fix space inside brackets {#252}[ruby-ldap/ruby-net-ldap#252]
* Rubocop style fixes {#249}[ruby-ldap/ruby-net-ldap#249]
* Lazy initialize Net::LDAP::Connection's internal socket {#235}[ruby-ldap/ruby-net-ldap#235]
* Support for rfc3062 Password Modify, closes #163 {#178}[ruby-ldap/ruby-net-ldap#178]
@dependabot-preview dependabot-preview bot mentioned this pull request Nov 1, 2018
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Jan 25, 2019
Open
@dependabot-preview dependabot-preview bot mentioned this pull request May 27, 2019
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Jun 6, 2019
Closed
@dependabot dependabot bot mentioned this pull request Jul 2, 2019
Merged
This was referenced Oct 14, 2019
Closed
Open
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Oct 30, 2019
Merged
This was referenced Nov 19, 2019
Closed
Merged
@dependabot dependabot bot mentioned this pull request Dec 17, 2019
Closed
@dependabot dependabot bot mentioned this pull request Jan 24, 2020
Closed
This was referenced Mar 4, 2020
Open
Closed
@dependabot dependabot bot mentioned this pull request Oct 1, 2020
Closed
@dependabot dependabot bot mentioned this pull request Oct 20, 2020
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Nov 13, 2020
Open
This was referenced Jan 24, 2023
Closed
Open
Open
This was referenced Jan 24, 2023
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Closed
Open
Merged
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Dec 18, 2023
Closed
@dependabot dependabot bot mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mynameisrufus @jch