Normalize the encryption parameter passed to the LDAP constructor #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| when :simple_tls, :start_tls | ||
| { :method => method, :tls_options => {} } | ||
| end | ||
| end |
There was a problem hiding this comment.
Looks good!
Could you make normalize_encryption do what #257 does?
There was a problem hiding this comment.
Sorry, what exactly would you like me to do? The method should take 1 of 4 types of arguments (nil, string, symbol, or hash) and return either nil or a hash.
There was a problem hiding this comment.
ah, sorry, I misunderstood. the purpose of this method is to normalize (I was thinking of validating a given encryption option when I saw your PR).
Anyway, please forget about my comment 🙇
jch
added a commit
that referenced
this pull request
Feb 3, 2016
Normalize the encryption parameter passed to the LDAP constructor
Closed
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 16, 2016
=== Net::LDAP 0.14.0
* Normalize the encryption parameter passed to the LDAP constructor {#264}[ruby-ldap/ruby-net-ldap#264]
* Update Docs: Net::LDAP now requires ruby >= 2 {#261}[ruby-ldap/ruby-net-ldap#261]
* fix symbol proc {#255}[ruby-ldap/ruby-net-ldap#255]
* fix trailing commas {#256}[ruby-ldap/ruby-net-ldap#256]
* fix deprecated hash methods {#254}[ruby-ldap/ruby-net-ldap#254]
* fix space after comma {#253}[ruby-ldap/ruby-net-ldap#253]
* fix space inside brackets {#252}[ruby-ldap/ruby-net-ldap#252]
* Rubocop style fixes {#249}[ruby-ldap/ruby-net-ldap#249]
* Lazy initialize Net::LDAP::Connection's internal socket {#235}[ruby-ldap/ruby-net-ldap#235]
* Support for rfc3062 Password Modify, closes #163 {#178}[ruby-ldap/ruby-net-ldap#178]
This was referenced Oct 14, 2019
This was referenced Nov 19, 2019
This was referenced Mar 4, 2020
This was referenced Jan 24, 2023
Closed
Open
Bump net-ldap from 0.11 to 0.16.2 in /_site/play-with-docker/Portus/Portus.1
PhuongTMR/dockerlabs#83
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores API functionality that was broken on 0.13, the encryption parameter can again be specified as a symbol and will be normalized to the expected hash.
This is in reference to #250