Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send DN and newPassword with password_modify request #271

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Send DN and newPassword with password_modify request #271

merged 1 commit into from
Oct 31, 2017

Conversation

thriqon
Copy link
Contributor

@thriqon thriqon commented May 18, 2016

This change allows an admin to overwrite the password of a user a) without specifying the old one and b) setting the new one.

@sonOfRa
Copy link
Contributor

sonOfRa commented Mar 15, 2017

This would be very useful for my setup, is it possible to get this merged soon-ish?

@jirutka
Copy link

jirutka commented Oct 27, 2017

@mtodd, @tmaher: Could you please merge this and release a new version? I spent half an hour trying to figure out why resetting password of an user doesn’t work (LDAP returns very confusing error message) until I found that it’s a bug in this gem.

Copy link
Member

@mtodd mtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 changes look good and consistent with the spec.

@mtodd mtodd merged commit 36815b5 into ruby-ldap:master Oct 31, 2017
@mtodd
Copy link
Member

mtodd commented Oct 31, 2017

This is now included in the v0.16.1 release and has been pushed up to RubyGems: https://rubygems.org/gems/net-ldap/versions/0.16.1

Thanks for putting together this quality PR @thriqon, and apologies for the slow turnaround on getting this merged and released. Your contribution is much appreciated!

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 14, 2018
=== Net::LDAP 0.16.1

* Send DN and newPassword with password_modify request {#271}[ruby-ldap/ruby-net-ldap#271]
This was referenced Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants