Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call-seq not honored in a certain case #792

Closed
BurdetteLamar opened this issue Feb 7, 2021 · 2 comments · Fixed by #840
Closed

Call-seq not honored in a certain case #792

BurdetteLamar opened this issue Feb 7, 2021 · 2 comments · Fixed by #840
Labels

Comments

@BurdetteLamar
Copy link
Member

BurdetteLamar commented Feb 7, 2021

The darkfish output for this method does not show the call-seq.

The alias is involved, because if it is omitted, the call-seq appears in the output.

The original error is seen in the darkfish output for REXML::Document#expaded_name, in rexml/lib/rexml/document.rb. (Actually, it's seen in my PR ruby/rexml#47.)

There is one other alias in that file, which does not cause the error.

This adapted code will show the error in its darkfish output:

class Foo

# :call-seq:
#   expanded_name -> empty_string
#
# Returns an empty string.
#
  def expanded_name
    ''
    #d = doc_type
    #d ? d.name : "UNDEFINED"
  end
  alias :name :expanded_name

end
@BurdetteLamar
Copy link
Member Author

It may be relevant that the alias is also overriding a method in the parent class, Element.

@flavorjones
Copy link
Contributor

I've submitted a fix for this at #840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants