Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code blocks by darkfish are not correctly rendered on Firefox #830

Closed
scivola opened this issue Aug 18, 2021 · 1 comment · Fixed by #844
Closed

Code blocks by darkfish are not correctly rendered on Firefox #830

scivola opened this issue Aug 18, 2021 · 1 comment · Fixed by #844

Comments

@scivola
Copy link

scivola commented Aug 18, 2021

Problem

Here is a part of the screen shot of https://ruby.github.io/rdoc/.

Screenshot-of-rdoc-documentation

The color of texts in a code block is black, so we cannot read it.

Cause

Under certain conditions, Firefox cannot render Source Code Pro font correctly: it ignores specified font color.
https://bugzilla.mozilla.org/show_bug.cgi?id=1520157

To solve it, Adobe released an new version of Source Code Pro:
adobe-fonts/source-code-pro#217 (comment)

Although the bug of Firefox still remain, the new version of Source Code Pro will work as expected.

Solution

The version of Source Code Pro used in rdoc is too old.
Replacing it with the new version will resolve this issue!
https://github.com/adobe-fonts/source-code-pro/releases

@aycabta
Copy link
Member

aycabta commented Oct 11, 2021

Thank you for your reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants