Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches and Tagging Don't Match Github Recommendations #55

Closed
wagenet opened this issue May 13, 2020 · 1 comment
Closed

Branches and Tagging Don't Match Github Recommendations #55

wagenet opened this issue May 13, 2020 · 1 comment

Comments

@wagenet
Copy link

wagenet commented May 13, 2020

Right now, v1 is a branch, which works, but there really should be a v1 tag pointing to the latest v1 release:

Move the major version tag (v1, v2, etc.) to point to the Git ref of the current release. For more information, see "Git basics - tagging."
https://help.github.com/en/actions/building-actions/about-actions#versioning-your-action

@eregon
Copy link
Member

eregon commented May 13, 2020

A moving tag is a git anti-pattern IMHO.
This has been discussed here: actions/toolkit#214
I think upstream decisions went wrong here, and it's unclear to me why v1 was ever a tag for some GitHub Actions.

A branch is much safer, idiomatic and disallows non-linear pushes, etc.
So I don't plan to change this, and there is already automation bumping the v1 branch on release.

The README is fairly clear about this:

This action follows semantic versioning with a moving v1 branch. This follows the recommendations of GitHub Actions.

Whatever relies on v1 being a tag should accept a branch too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants