Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using RFC_3986 with URI::Generic.build #104

Closed
alexanderfletcher opened this issue May 2, 2024 · 2 comments · Fixed by #107
Closed

using RFC_3986 with URI::Generic.build #104

alexanderfletcher opened this issue May 2, 2024 · 2 comments · Fixed by #107

Comments

@alexanderfletcher
Copy link

With URI::Generic you can pass in a custom parser (or the in built RFC_3986 one). However build uses the default parser. Would it be possible to extend the build method to allow to pass a parser in?

It's also a bit confusing that the parse methods uses RFC3986 while the build method uses the older RFC2396

@gareth
Copy link

gareth commented May 28, 2024

I made a patch to address this on the ruby-lang bugs list a year ago, at the time I didn't realise that the URI library was maintained on Github.

I only just saw @jeremyevans' comment on that issue, so I'll port that patch over to Github tomorrow and submit it as a PR.

@gareth
Copy link

gareth commented May 28, 2024

So my PR #105 doesn't exactly resolve this issue but does change the default parser for URI::Generic.build (with justification in the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants