From e4efb4a2300540f14f93c09c06bf0357ac1597dc Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Thu, 11 Jul 2024 15:02:21 -0700 Subject: [PATCH] Remove unnecessary gsub calls in test_httprequest.rb --- test/webrick/test_httprequest.rb | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/test/webrick/test_httprequest.rb b/test/webrick/test_httprequest.rb index ad00d60..84faefc 100644 --- a/test/webrick/test_httprequest.rb +++ b/test/webrick/test_httprequest.rb @@ -89,7 +89,7 @@ def test_invalid_content_length_header HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {8}/, "").gsub("\n", "\r\n"))) + req.parse(StringIO.new(msg)) } end end @@ -102,7 +102,7 @@ def test_bare_lf_request_line HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } end @@ -114,7 +114,7 @@ def test_bare_lf_header HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } end @@ -125,7 +125,7 @@ def test_header_vt_ff_whitespace \r HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) assert_equal("\x0b1\x0c", req["Foo"]) msg = <<~HTTP @@ -135,7 +135,7 @@ def test_header_vt_ff_whitespace \r HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) assert_equal("\x0b1\x0c \x0b2\x0c", req["Foo"]) end @@ -147,7 +147,7 @@ def test_bare_cr_request_line HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } end @@ -159,7 +159,7 @@ def test_bare_cr_header HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } end @@ -171,7 +171,7 @@ def test_invalid_request_lines HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } msg = <<~HTTP.gsub("\n", "\r\n") @@ -181,7 +181,7 @@ def test_invalid_request_lines HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } msg = <<~HTTP.gsub("\n", "\r\n") @@ -191,7 +191,7 @@ def test_invalid_request_lines HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } msg = <<~HTTP.gsub("\n", "\r\n") @@ -201,7 +201,7 @@ def test_invalid_request_lines HTTP req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ - req.parse(StringIO.new(msg.gsub(/^ {6}/, ""))) + req.parse(StringIO.new(msg)) } end @@ -427,7 +427,6 @@ def test_null_byte_in_header Evil: evil\x00\r \r HTTP - msg.gsub!(/^ {6}/, "") req = WEBrick::HTTPRequest.new(WEBrick::Config::HTTP) assert_raise(WEBrick::HTTPStatus::BadRequest){ req.parse(StringIO.new(msg)) } end