Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger check for "unpackaged" code #8

Open
alexevanczuk opened this issue Apr 19, 2022 · 1 comment
Open

Danger check for "unpackaged" code #8

alexevanczuk opened this issue Apr 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@alexevanczuk
Copy link
Contributor

To package all of our files, Gusto has created a pack (see stimpack) called packs/unpackaged_code_that_needs_to_be_organized. All code that we couldn't find a home for we put there, with the intent that users would gradually move it into other packs.

Gusto has an internal danger plugin to aid us with this process. When a new file is created in that pack, we ask them to not create new files that are not packaged. When a file is modified, we ask if they have additional context that could permit them to move the file to a more appropriate pack.

If there is interest, we could port this over to danger-packwerk (with a configurable name for the unpackaged pack).

@alexevanczuk alexevanczuk added the enhancement New feature or request label Apr 19, 2022
@schoblaska
Copy link
Contributor

This seems like potentially a good idea! Leaving this issue open for now to track, though it is probably low priority for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants