Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger check for packwerk validate (acyclic dependencies) #9

Open
alexevanczuk opened this issue Apr 19, 2022 · 1 comment
Open

Danger check for packwerk validate (acyclic dependencies) #9

alexevanczuk opened this issue Apr 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@alexevanczuk
Copy link
Contributor

alexevanczuk commented Apr 19, 2022

It could be interesting to include a danger check when bin/packwerk validate fails due to cyclic dependencies.

This is a great entry point to start a conversation about what the ideal dependency order should be, so being notified about this and using it as an educational moment could be helpful.

Gusto does not have this check internally today. If there is interest, this could be a cool check to add.

Note this might require some changes upstream to permit validate to return a structured response, but I haven't yet investigated whether the validate command can already return structured objects when using the ruby (i.e. not CLI) API.

@alexevanczuk alexevanczuk added the enhancement New feature or request label Apr 19, 2022
@schoblaska
Copy link
Contributor

This seems like potentially a good idea! Leaving this issue open for now to track, though it is probably low priority for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants