-
-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add compare view between gem versions #1853
Comments
What are you suggesting we show on the diff page? Are you suggesting we extract and diff the files for every gem version? |
extract files of requested versions and run a diff on them ... maybe have some limit on number of files/size (don't diff images etc stuff) Maybe more efficient to make a git repo per gem and have all versions as tags ... could host that independently anyway ... would be pretty awesome tool to build things on ... |
we can just link to http://diff.coditsu.io 🤷♂ |
Hey. I'm the author of the differ. Couple things related to it:
|
Hi, this has a PR #2499 and we will be closing this issue when that gets merged. Please check the pr/site if you have comments. |
Closed by #2499 |
Problem: Github is not a reliable source version diff (because it is sometimes not linked, sometimes not tagged, sometimes does not show the exact diff)
Solution: "compare [v1.2.3] to [v1.2.2]" form with 2 selects so users can see the exact diff of what they are about to install, will be useful when making gem bump PRs to link these.
Bonus: the compare page can link to the source-control compare if available #1630.
Related:
/cc @sinsoku
The text was updated successfully, but these errors were encountered: