Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few parts of the about page is not properly localized #4042

Open
nobu opened this issue Sep 3, 2023 · 3 comments · Fixed by #4149
Open

A few parts of the about page is not properly localized #4042

nobu opened this issue Sep 3, 2023 · 3 comments · Fixed by #4149
Labels

Comments

@nobu
Copy link

nobu commented Sep 3, 2023

A few parts of the about page is not properly localized.

Steps to Reproduce

  1. Access the page above, with locales other than English.

Expected Behavior

This page should be translated in the target language.

Current Behavior

Japanese version page, for instance.

  • .founding_html paragraph:

    2009年4月にNick Quarantoの手によって発足したプロジェクトは、現在350 Rubyistsの貢献を得てmillions of gem downloadsに到るまで成長を遂げました。

    As you can see, the linked phrases are not translated.
    The first part is a proper noun and ok of course.
    But "350 Rubyists" and "millions of gem downloads" are not.

  • . technical_html paragraph:

    このサイトの技術的な側面に目を向けるなら、100% Rubyでできています。サイトの主要な部分はRailsアプリケーションです。gemはAmazon S3上にホストされ、Fastlyによりサーブされており、新しく公開したgemがインストール可能になるまで通常はほんの数秒です。詳細はplease check out the code。GitHub上でMIT licensedとなっています。

    The phrase "please check out the code" is not translated.
    "MIT licensed" is a subtle as a translation too, since the phrase is an adjective while the link target is a noun.

  • Also, about__assets__heading is not translated at all.

Possible Solution

As for .founding_html, I think this would be better:

  • "over 350 Rubyists" should be "350人以上のRubyist"
  • "millions of gem downloads" should be "何億回ものgemダウンロード"

Note that the order of word "over"("以上") differs in Japanese than English, it can't be placed outside "350 Rubyists".
Or "Rubyist 350人以上" is not wrong, but not better.

Environment

Browser and its version: any browsers send and handle "Accept-Language" properly.
RubyGems version: unrelated.

Additional Context

@nobu nobu added the bug label Sep 3, 2023
@simi
Copy link
Member

simi commented Sep 10, 2023

Thanks for the report @nobu. I'll open PR to make those parts "translatable". Once ready, it should be easy to submit PR to fix those problems.

@simi
Copy link
Member

simi commented Sep 10, 2023

@nobu those parts reported as not translated are now extracted in separate keys. Would you mind to open PR to translate those?

If that's easier, feel free to just fill in those YAML values and comment back, I'll open PR and handle rest. You can find more context at #4063.

  pages:
    about:
      contributors_amount:
      downloads_amount:
      checkout_code:
      mit_licensed:
      logo_header:
      logo_details:

this is english version for reference

  pages:
    about:
      contributors_amount: "%{count} Rubyists"
      downloads_amount: "millions of gem downloads"
      checkout_code: "please check out the code"
      mit_licensed: "MIT licensed"
      logo_header: Looking for our logo?
      logo_details: Just select the download button and you'll get three .PNGs and an .SVG of the RubyGems logo all for yourself.

@martinemde
Copy link
Member

I think there's more to do here. This auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants