Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Wrap documentPath.fsPath in single quotes to support file paths with spaces #647

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

coneybeare
Copy link
Contributor

@coneybeare coneybeare commented Aug 8, 2020

Closes #641

Description of change and why it was needed here

Single quotes around the documentPath.fsPath is necessary to support file paths that include spaces.

  • The build passes
  • TSLint is mostly happy
  • Prettier has been run

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #647 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #647   +/-   ##
======================================
  Coverage    5.08%   5.08%           
======================================
  Files          10      10           
  Lines         118     118           
  Branches       20      20           
======================================
  Hits            6       6           
  Misses        112     112           
Flag Coverage Δ
#language_server_ruby 5.08% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/language-server-ruby/src/formatters/Rufo.ts 0.00% <0.00%> (ø)
...es/language-server-ruby/src/formatters/Standard.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1124efc...d432fee. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 8, 2020

This PR has not had activity for 30 days. It will be automatically closed in 7 days.

@coneybeare
Copy link
Contributor Author

coneybeare commented Mar 30, 2021

I think the formatting needs to be different when using the language server or not. Here is my initial bug report, and the reason for the PR: #641. Feel free to tweak in a new PR, as long as commands still run in scripts within directories that have spaces. I have no strong opinions on implementations

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubocop requires relative paths
2 participants