Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements #286

Closed
tisba opened this issue Jun 3, 2023 · 1 comment
Closed

CI Improvements #286

tisba opened this issue Jun 3, 2023 · 1 comment

Comments

@tisba
Copy link
Collaborator

tisba commented Jun 3, 2023

Inspired by: #276

  • build and then install the gem and do a smoke test to see if it is in fact working.

    I removed *.c from the resulting gem bundle (🤦) in gemspec: Exclude *.bundle (follow-up #281) #285 and builds where still passing. IMO this should be easy to catch.

  • install and smoke test with various ruby versions.

    In a relatively simple sanity check, we could test (e.g. using Docker) that mini_racer is installable and works with the "standard" Ruby docker images. These are pretty heavily used in the community and IMO it would be helpful to have some sort of confirmation that these work in general. We could start with ruby:3.0, ruby:3.1 and ruby:3.2 (see https://hub.docker.com/_/ruby).

@tisba
Copy link
Collaborator Author

tisba commented Jul 4, 2024

Addressed by #304

@tisba tisba closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant