Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all "Unapprove" , replace with "Disapprove" #86

Open
ferbsx opened this issue Nov 9, 2015 · 1 comment
Open

Remove all "Unapprove" , replace with "Disapprove" #86

ferbsx opened this issue Nov 9, 2015 · 1 comment
Labels

Comments

@ferbsx
Copy link
Member

ferbsx commented Nov 9, 2015

Since unapprove is not an English word.

@ferbsx ferbsx self-assigned this Nov 9, 2015
@ferbsx ferbsx changed the title Remove all "Unapprove" to "Disapprove" Remove all "Unapprove" , replace with "Disapprove" Nov 9, 2015
@fidothe
Copy link
Member

fidothe commented Dec 1, 2015

Unapprove is fine, IMO. Disapprove means to "have or express an unfavourable opinion". Unapproved means "not officially accepted or sanctioned", and although unapprove as a verb isn't common, disapprove really doesn't work. You don't disapprove something, you disapprove of something, it's an opinion not a statement of fact.

Being pedantic you'd need something like "revoke approval" to denote moving something from approved to unapproved status, but using "unapprove" as a verb seems more obvious to non-native speakers to me.

Opinions may vary 😸

@ferbsx ferbsx removed their assignment Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants