fix: auto-session un-cleared on dynamically disabling trackLifeCycleEvents & autoSessionTracking #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling track life cycle events
desusai7
changed the title
desusai7
changed the title
1abhishekpandey
approved these changes
Jul 19, 2023
pallabmaiti
approved these changes
Jul 20, 2023
|
Kudos, SonarCloud Quality Gate passed! |
1abhishekpandey
added a commit
that referenced
this pull request
Jul 31, 2023
* chore: added credit to NSData+GZIP (#341) * fix: event not getting removed from DB and certain processing issue (#340) * fix: event not getting removed from DB and certain processing issue * fix: application update event logic * refactor: the firstEventTimestampBeforeSDKInit() logic Now, the value will be stored into the UserDefault to cover the case where events are made while SDK is init but even before it complete its execution SDK stop e.g., writeKey error. * chore: address Sonarcloud bug and code smell issue * chore: addressing comments Refactored most of the logic. * chore: remove leftover codes * chore: refactor RSEventDeletionStatus key in preference manager * refactor: device mode events processing logic * fix: improve the logic of isDeviceModeFactoriesNotPresent property * chore: addressing comments * code refactored * fix: use correct variable name for rowId --------- Co-authored-by: Pallab Maiti <[email protected]> * fix: replay message queue dumping logic (#348) * fix: replay message queue dumping logic * revert: previous logic to mark events as device mode processing done on App Update * test: add new db unit test case and fix old one * fix: fixed application installed and updated getting triggered in-correctly (#345) Co-authored-by: Desu Sai Venkat <[email protected]> Co-authored-by: Abhishek Pandey <[email protected]> * fix: fixed automatic session not getting cleared on dynamically disabling track life cycle events (#344) Co-authored-by: Desu Sai Venkat <[email protected]> Co-authored-by: Abhishek Pandey <[email protected]> * chore(release): 1.16.1 --------- Co-authored-by: Pallab Maiti <[email protected]> Co-authored-by: Abhishek Pandey <[email protected]> Co-authored-by: Pallab Maiti <[email protected]> Co-authored-by: Desu Sai Venkat <[email protected]> Co-authored-by: Desu Sai Venkat <[email protected]> Co-authored-by: GitHub actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fixed automatic session not getting cleared on dynamically disabling track life cycle events / automatic session tracking
The previous automatic session would still be active, if we disable the track life cycle events on next launch, hence we need to save the automatic tracking status as enabled in the preferences only when both track life cycle events and automatic session tracking is enabled.