Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login for madrid.rb #1063

Open
phoet opened this issue Oct 14, 2024 · 9 comments
Open

Login for madrid.rb #1063

phoet opened this issue Oct 14, 2024 · 9 comments
Labels

Comments

@phoet
Copy link
Member

phoet commented Oct 14, 2024

I just received this email, could you help re-onbaord @josepegea ?

Email edited out

TL:DR:

  • Log in with Twitter to madridrb.com doesn't work in browsers that never had a previous session.
  • Twitter login does still work in browsers that were used in a previous session, even after logging out
  • Connecting from GitHub, even from an account with the same email fails with an Error 500.

It's clear from #1034 that this has happened to more users. Knowing a recommended course of action would be great. Thanks

@JoschkaSchulz
Copy link
Member

sure, lets fix all the small things that got broken in the past :)

@josepegea
Copy link
Collaborator

Well, after sending the message above I thought about looking at issues and I found #1034

It's mentioned there that a possible workaround would be to register with a GitHub account that used the exact same email address that was used on Twitter. It doesn't work for me, but maybe there's something else in my case.

Some other users of Madrid.rb are just finding this issue (and I guess it must have happened to users of other communities, too). I'd like to provide them with a solution. Thanks

@phoet
Copy link
Member Author

phoet commented Oct 15, 2024

The GitHub workaround was just an idea, I was not sure weather it would work. Actually good that it does not from a security perspective 😸

So there are some solutions that come to my mind:

a) register a new user and manually copy the authorization to the old user, discarding the new one afterwards
b) write a small piece of code that sends out an invitation link where a user gains a login-session with the connected user of the email. through that a user can connect to an authorization provider of choice
c) add email+password login and allow password reset

b and c have the drawback that it only works if you still have access to the registered email account.

@phoet
Copy link
Member Author

phoet commented Oct 15, 2024

You could use my one-time-password-email-auth-provider for omniauth that i use at weg.li in order to provide password-less logins via email login links https://github.com/weg-li/weg-li/blob/master/app/lib/omni_auth/strategies/email.rb

@phoet
Copy link
Member Author

phoet commented Oct 15, 2024

PS:

F U ELON!

@phoet
Copy link
Member Author

phoet commented Oct 15, 2024

@josepegea regarding the login via twitter with an existing session: the site has a remember-me cookie that probably does a login in some kind of way. the actual twitter auth is dead, that cant work.

@salzig
Copy link
Collaborator

salzig commented Oct 15, 2024

@phoet OTP-email is a nice idea.

@josepegea
Copy link
Collaborator

I'll try to add the email login, although it will most likely be during the weekend

@josepegea
Copy link
Collaborator

Ok, I finally found the time to finish the Email OTP Auth thing. See the PR at #1068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants