Question about SimplePropertyGraphStore

[yingflower]

In file of : core/graph_stores/simple_labelled.py

class SimplePropertyGraphStore(PropertyGraphStore):

The function get is defined like this:

def get(
self,
properties: Optional[dict] = None,
ids: Optional[List[str]] = None,
) -> List[LabelledNode]:
"""Get nodes."""
nodes = list(self.graph.nodes.values())
if properties:
nodes = [
n
for n in nodes
if any(n.properties.get(k) == v for k, v in properties.items())
]

    # Filter by node_ids
    if ids:
        nodes = [n for n in nodes if n.id in ids]

    return nodes

If the properties and ids are all set to None, or are all empty, we will get all of the nodes stored in the graph store.
Is this ok?

[yingflower]

Update the code part:

   def get(
        self,
        properties: Optional[dict] = None,
        ids: Optional[List[str]] = None,
    ) -> List[LabelledNode]:
        """Get nodes."""
        nodes = list(self.graph.nodes.values())
        if properties:
            nodes = [
                n
                for n in nodes
                if any(n.properties.get(k) == v for k, v in properties.items())
            ]

        # Filter by node_ids
        if ids:
            nodes = [n for n in nodes if n.id in ids]

        return nodes