Plan queue functionality

[monikma]

Hi there!

In our organisation we are using Atlantis to manage a terraform repository that holds all of our infrastructure definitions. We have around 100 engineers, and all of them can make changes to the common terraform repository. This creates a lot of "waiting for the lock" situation, stealing the lock, and sometimes becomes quite a hell. We have separate lock per environment, but still that does not help.

In one of our hackathons a couple of developers checked out this repo and added a functionality where a plan command would be queued instead of failing if the lock is currently not available. Atlantis would then automatically replay the queued command once the lock is released (applies are not done automatically, only plans). We see that this would help us tremendously. We have the feature ready and working for us, what is missing is tests, perhaps a nicer code design.

We would be very interested in publishing a pull request to this repository with our feature. We would of course polish it up before, and make production ready. How much interest for such feature would be there? Has such functionality been ever talked about? How do we increase our chances of the pull request being accepted?

Regards,
Monika

[nishkrishnan]

Hi @monikma I would be open to reviewing a pull request for this. We've definitely talked about this functionality internally.

[monikma]

@nishkrishnan it is now ready for review here #1923, please kindly provide your feedback.

[tiagoasousa]

Was this idea abandoned? seems the pr´s related to it are closed

[nitrocode]

Looks like the pr was closed because @ScaCap deleted the fork

[ghaiszaher]

@tiagoasousa @nitrocode indeed, sorry for this. Unfortunately the repo had to be deleted from the organization. We wanted to raise a new PR from another fork right away but we got caught up in work and there were also some conflicts due to introducing Redis DB. For now I'll just extend the implementation in Redis by throwing Unsupported feature error, but that's not ideal.

Here is the draft PR for now: #2782, still needs some polishing but feel free to drop your comments there. I will reply in the original PR about the new one once raised.

[nitrocode]

Thank you so much @ghaiszaher for your contribution and your patience here. We will try to review as soon as possible. Your contribution makes a difference.

[tiagoasousa]

Thanks a lot for following up on this!

[nitrocode]

Another solution worth considering is finding a way to safely disable atlantis locking.

Please see this issue for more information #2876