Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a draft PR will run atlantis plan again #1194

Closed
jolexa opened this issue Sep 21, 2020 · 4 comments · Fixed by #1195
Closed

Editing a draft PR will run atlantis plan again #1194

jolexa opened this issue Sep 21, 2020 · 4 comments · Fixed by #1195

Comments

@jolexa
Copy link
Contributor

jolexa commented Sep 21, 2020

Quick note: With autoplanning on draft PRs, if you edit the PR main comment a new plan will be ran every time. Note: No code changes, just the PR description will trigger this re-plan

atlantis version: v0.15.0

Steps to reproduce:

  1. Open draft PR
  2. Wait for plan output
  3. edit PR description
  4. Observe new plan output with no code changes done
@jolexa jolexa changed the title Editting a draft PR will run atlantis plan Editing a draft PR will run atlantis plan again Sep 21, 2020
@lkysow
Copy link
Member

lkysow commented Sep 22, 2020

Can you find out what API call github is sending when you edit the description?

@jolexa
Copy link
Contributor Author

jolexa commented Sep 22, 2020

I think it is this one:
X-GitHub-Event: pull_request
with Payload :
"action": "edited",
and "changes": { "body": { "from": "<existing text that was changed>" }

Does that help?

@lkysow
Copy link
Member

lkysow commented Sep 22, 2020

Try :latest. I think I fixed it.

@jolexa
Copy link
Contributor Author

jolexa commented Sep 22, 2020

Try :latest. I think I fixed it.

Nice, super fast, thanks! It is not trivial for me to test at the moment (we use atlantis at work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants