terraform logs streaming feature removed web authentication in atlantis 0.18

[fvdnabee]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

When #1937 was merged, the (improved) auth support merged in #1896 was removed. In 0.18.1 HTTP auth isn't enforced at all.

Reproduction Steps

Run atlantis 0.18.1 with --web-basic-auth=true, surf to http://localhost:4141 and you are not greeted by an HTTP Auth browser dialog. This is working in atlantis 0.17.5.

Logs

Logs

Atlantis 0.18.1 returns 200 immediately eventhough --web-basic-auth=true is set:

{"level":"debug","ts":"2022-01-06T11:05:18.021+0100","caller":"server/middleware.go:35","msg":"GET / – from 127.0.0.1:42094","json":{}}
{"level":"info","ts":"2022-01-06T11:05:18.021+0100","caller":"server/server.go:849","msg":"Apply Lock: {false 0001-01-01 00:00:00 +0000 UTC }","json":{}}
{"level":"debug","ts":"2022-01-06T11:05:18.021+0100","caller":"server/middleware.go:37","msg":"GET / – respond HTTP 200","json":{}}

Atlantis 0.17.5 returns 401 as you'd expect:

{"level":"debug","ts":"2022-01-06T11:04:29.497+0100","caller":"server/middleware.go:44","msg":"GET / – from 127.0.0.1:42092","json":{}}
{"level":"debug","ts":"2022-01-06T11:04:29.497+0100","caller":"server/middleware.go:68","msg":"GET / – respond HTTP 401","json":{}}

Environment details

• Atlantis version: 0.18.1
• Flags: --web-basic-auth=true

Additional Context

None.

[Aayyush]

Thank you for the catch! I've sent out a PR with the fix: #2008

[fvdnabee]

Thank you, @Aayyush.

This appears to be released in atlantis v0.18.2 (I didn't test it though), so I'm closing this.