Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Atlantis should support gitHub groups for approving polices along with individual users #2116

Open
stark-tech25 opened this issue Mar 4, 2022 · 1 comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors

Comments

@stark-tech25
Copy link

stark-tech25 commented Mar 4, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

Currently Atlantis only supports individual users as owners to approve failed policies. Each user needs to be hardcoded in the atlantis.yaml
Having the option to use a GitHub team would extend this feature to all members of the group with out having to hard code each member in the config.

Atlantis server-side config file:

Repo atlantis.yaml file:

**Current Implementation:**
    repos:
    - id: github.test/test
      apply_requirements: []
      workflow: test
      allowed_overrides: []
      allow_custom_workflows: false
    policies:
      owners:
        users:
          - user1
          - user2
      policy_sets:
        - name: atlantis-conf-tests
          owners:
            users:
              - user1
              - user2
          path: /github_atlantis/policy
          source: local  
**Expected feature**
    repos:
    - id: github.test/test
      apply_requirements: []
      workflow: test
      allowed_overrides: []
      allow_custom_workflows: false
    policies:
      owners:
        team:
          - team1
      policy_sets:
        - name: atlantis-conf-tests
          owners:
            team:
              - team1
          path: /github_atlantis/policy
          source: local  
@stark-tech25 stark-tech25 added the bug Something isn't working label Mar 4, 2022
@chenrui333 chenrui333 added feature New functionality/enhancement help wanted Good feature for contributors and removed bug Something isn't working labels Mar 4, 2022
@chenrui333 chenrui333 changed the title Feature: Atlantis should support gitHub groups for approving polices along with individual users feature: Atlantis should support gitHub groups for approving polices along with individual users Mar 4, 2022
@guidor
Copy link

guidor commented Jun 9, 2023

I think this was added in v0.24.0 #3086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement help wanted Good feature for contributors
Projects
None yet
Development

No branches or pull requests

3 participants