v0.21+: Policy check summary not shown outside of "Show Output" details

[DanielCastronovo]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

#2452

Reproduction Steps

Launch a plan and viewed the result for security steps.

Logs

Environment details

• Atlantis version: 0.21.0

Additional Context

We doesn't view the summary on a security checks.
Related to this PR #2452

[nitrocode]

@DanielCastronovo perhaps your output is not matching the regex expected for opa/conftest?

Could you add more details? What policy are you running? Example of the hcl file? What does the policy run output show locally?

@tlorreyte since you proposed PR #2452 in case you have some thoughts on this.

[tlorreyte]

@nitrocode I know @DanielCastronovo 's context. If this has not changed, a custom workflow is used for security checks.
The regex does not match the conftest output? or is it only in the case of a custom message?

[nitrocode]

Unsure, but from the screenshot posted above, it appears that the policy summary is empty

[DanielCastronovo]

The summary is correctly fill, see the details in this screenshot.
The regex seems to be good.

[nitrocode]

@DanielCastronovo i don't understand the problem

[DanielCastronovo]

Regarding the description of the PR :

Currently the only way to get a summary of the Conftest output (ie the last line) is to expand the comment.

When the security check comment is very long, it could be annoying to scroll down until find the summary line (v tests, w passed, x warnings, y failures, z exceptions).

Like the Terraform plan output, it might be interesting to have the summary of the Conftest result in the reduced comment

It should display the summary on the comment, without needing to be expended.
Like this :

[nitrocode]

Ah ok, I understand the problem now. So the policy check summary is no longer shown outside of the "show output" detail drop down

cc: @tlorreyte

[tlorreyte]

It's due to a conflict with #2647 imho. The new wrapped template file doesn't have {{.PolicyCheckSummary}}. I'll open a pr

[DanielCastronovo]

Many thanks @tlorreyte ❤️

[nitrocode]

@tlorreyte friendly ping before the holidays :)