Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Skip adding PR comments for successful policy checks #2764

Closed
DazWorrall opened this issue Dec 9, 2022 · 2 comments
Closed

feat: Skip adding PR comments for successful policy checks #2764

DazWorrall opened this issue Dec 9, 2022 · 2 comments
Labels
feature New functionality/enhancement

Comments

@DazWorrall
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

We have policy checking enabled in our organisation, and the vast majority of PRs do not violate any of policies. That means for most of our changes, the Ran Policy Check comment is at best redundant and at worst a bit of a nuisance - it makes it harder for users to find and inspect the plan. The successful atlantis/policy_check CI status is sufficient to show that the policy checks have passed, so it would be great to have an option to disable the policy check comments unless there is a failure/violation.

@DazWorrall DazWorrall added the feature New functionality/enhancement label Dec 9, 2022
@DazWorrall
Copy link
Contributor Author

I would be willing to take look at this with some guidance - should there be a generic feature to classify messages as optional/informational and a config option to configure if they are posted, or a solution specific to the policy checking feature?

@DazWorrall
Copy link
Contributor Author

Never mind, this was solved in #2405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant