"allow-mergeable-bypass-apply" feature crashes on v0.22.0

[stasostrovskyi]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

When using --gh-allow-mergeable-bypass-apply, Atlantis cannot check whether PR is mergeable or not due to a bug in go-github package (google/go-github#2606). This is already fixed in go-github v49 (currently v48 is used).

Reproduction Steps

1. Enable --gh-allow-mergeable-bypass-apply on Atlantis server
2. Add atlantis apply comment and see it fail every time.

Logs

Logs

{"caller":"events/apply_command_runner.go:114", "json":{…}, "level":"warn", "msg":"unable to get pull request status: fetching mergeability status for repo: nordnet-private/gcp-domain-base, and pull number: 246: getting pull request status: getting required status checks: json: cannot unmarshal object into Go struct field Protection.lock_branch of type bool. Continuing with mergeable and approved assumed false", "stacktrace":"github.com/runatlantis/atlantis/server/events.(*ApplyCommandRunner).Run
	github.com/runatlantis/atlantis/server/events/apply_command_runner.go:114
github.com/runatlantis/atlantis/server/events.(*DefaultCommandRunner).RunCommentCommand
	github.com/runatlantis/atlantis/server/events/command_runner.go:296", "ts":"2023-01-03T10:04:12.837Z"}

Environment details

• Atlantis version: 0.22.0
• Atlantis flags: only relevant - --gh-allow-mergeable-bypass-apply

[stasostrovskyi]

@nitrocode It would be awesome if you or someone else from maintainers can check a checkbox in Renovate's Dependency Dashboard to update go-github version. Thank you in advance!

[nitrocode]

I did check that box which created #2928. It originally only added the v49 dependency instead of replacing the v48 dependency. Then @krrrr38 saw that this was a misconfiguration in renovatebot and added #2929. After merging that and retriggering #2928, i then merged the PR.

Once this run is complete, could you check the new dev tagged image to see if it resolves this issue?

[darron]

The tagged :dev image resolved the issue for us today.