Bug: Running apply twice bypasses policies

[pseudomorph]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

Running either atlantis apply or a targeted apply twice on a PR which has failing policies results in the project(s) being applied.

Reproduction Steps

1.) Open PR which contains changes that result in failing policies.
2.) Get the PR into a mergeable state.
3.) Run an apply command twice. Any of the following should work.

• atlantis apply, then atlantis apply
• apply, then targeted apply
• 2 targeted applies

Looks like requirement checker is checking for errored policy status on the project: https://github.com/runatlantis/atlantis/blob/main/server/events/command_requirement_handler.go#L50

But when the apply fails after this requirement check, the project status is shifted to failed apply: https://github.com/runatlantis/atlantis/blob/main/server/events/command/project_result.go#L53

Logs

Environment details

Additional Context

[nitrocode]

Good find! Please feel free to propose a PR. We need more eyes on this stuff :)

[pseudomorph]

I've tacked on a fix to the granular policy sets PR.