Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Support for Customising the Shell for Pre and Post Workflow Hooks #3447

Closed
1 task done
X-Guardian opened this issue May 24, 2023 · 2 comments · Fixed by #3451
Closed
1 task done

feat: Add Support for Customising the Shell for Pre and Post Workflow Hooks #3447

X-Guardian opened this issue May 24, 2023 · 2 comments · Fixed by #3451
Labels
feature New functionality/enhancement

Comments

@X-Guardian
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

As a user of Atlantis, I would like to use shells other than sh for my pre and post workflow hooks (Bash, PowerShell etc).

Describe the solution you'd like

Have two additional, optional properties on the workflow hooks, specifying the shell and shell arguments, i.e.

repos:
- id: /.*/
  pre_workflow_hooks:
    -  description: bash test
       shell: bash
       shellArgs: -c
       run: echo $SHELL

The script will then be run using the specified shell and shellArgs, rather than the default sh -c. If the new properties are not
specified, sh -c will be used by default, so this is a non-breaking change.

Describe the drawbacks of your solution

Non identified

Describe alternatives you've considered

Non identified

@X-Guardian X-Guardian added the feature New functionality/enhancement label May 24, 2023
@nitrocode
Copy link
Member

Why not customize it for all steps, not just pre and post workflow hooks?

I think we have an issue for this already

@nitrocode
Copy link
Member

Related issue #2177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants