Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing changes due to doc label during GH release #3667

Closed
GenPage opened this issue Aug 12, 2023 · 2 comments · Fixed by #3790
Closed

Missing changes due to doc label during GH release #3667

GenPage opened this issue Aug 12, 2023 · 2 comments · Fixed by #3790
Assignees
Labels
bug Something isn't working

Comments

@GenPage
Copy link
Member

GenPage commented Aug 12, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Overview of the Issue

When drafting releases, PRs that are tagged with the "doc" label are purposely kept out of the changelog notes. However, this includes PRs where "doc" is not the only label. We have a workflow that auto-tags PRs based on file changes so PRs are getting auto-tagged with "doc" if they update docs alongside their contribution.

Additional Context

Labeler: https://github.com/runatlantis/atlantis/blob/main/.github/labeler.yml#L8-L10
Release: https://github.com/runatlantis/atlantis/blob/main/.github/release.yml#L2-L6
Slack Context first reported: https://atlantis-community.slack.com/archives/C04ES70Q6E8/p1689194658128239
PRs affected:

@GenPage GenPage added the bug Something isn't working label Aug 12, 2023
@GenPage GenPage self-assigned this Aug 12, 2023
@X-Guardian
Copy link
Contributor

@GenPage, the release notes were never manually updated with the missing PRs. Could this be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants