fix: setup-go in CI to resolve cache warnings #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
fix-setup-go
branch
2 times, most recently
from
14f2295
to
384798a
Compare
austinvazquez
commented
Jun 28, 2023
ginglis13
reviewed
Jun 28, 2023
austinvazquez
force-pushed
the
fix-setup-go
branch
2 times, most recently
from
3271d86
to
0412c74
Compare
|
Marking ready to review. The test failures are showing on multiple other PRs, so I believe them to be unrelated to my code changes. |
ginglis13
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Test failures are the same we've seen across finch and finch-core. They're be resolved once nerdctl upgrades buildkit to 0.12.0 -> cuts a release -> lima consumes that new release -> lima cuts a release -> we pull in that release :) . I'm ok to merge these changes 👍
|
Actually it looks like a fix for actions/setup-go#368 has been merged. Can we re-enable cache now? |
austinvazquez
force-pushed
the
fix-setup-go
branch
from
0412c74
to
f86d546
Compare
Updated to enable caching across the board. |
ginglis13
reviewed
Jul 20, 2023
austinvazquez
force-pushed
the
fix-setup-go
branch
from
f86d546
to
7b734d3
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-setup-go
branch
from
7b734d3
to
ff2fe31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Have checkout before setup-go to resolve cache warnings.
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.