feat: rootfs - build/upload action and Dockerfile #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
force-pushed
the
rootfs-dockerfile
branch
11 times, most recently
from
bf05eef
to
3079cc4
Compare
|
GitHub secrets are not evaluated on PRs from forks (so as not to allow for bad actors to expose secrets). I've updated the PR to be ready for review, but it the action won't run until merge. |
ginglis13
changed the title
vsiravar
approved these changes
Jul 21, 2023
ginglis13
force-pushed
the
rootfs-dockerfile
branch
from
3079cc4
to
4ac8cee
Compare
pendo324
approved these changes
Jul 25, 2023
ginglis13
force-pushed
the
rootfs-dockerfile
branch
from
4ac8cee
to
9c08963
Compare
In order to facilitate Finch on Windows, we need a root filesystem. We will use this Dockerfile as a basis for that root filesystem - using `docker export` to turn a built container into an archived rootfs. For the scope of these changes, create the Dockerfile and an action that runs on changes to the file to build and push to ECR repo. In order to create the container used as an intermediate step to export its rootfs, we need to tell buildkit to load the image into Docker. This exposes a limitation of buildkit to load multiplatform images, thus why the action runs two build-rootfs-image jobs - one for each arch. Additionally, network performance of the arm64 build is quite slow - downloads of packages via dnf are on the scale of kb/s (but this has not been observed on Ubuntu or Alpine images) Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
force-pushed
the
rootfs-dockerfile
branch
from
9c08963
to
5360963
Compare
pendo324
approved these changes
Jul 27, 2023
vsiravar
approved these changes
Jul 27, 2023
|
CI failing for known reason described in runfinch/finch#461 (comment) |
|
Missing auth in https://github.com/runfinch/finch-core/actions/runs/5684511073/job/15407368457:
Need to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
runfinch/finch#492
Description of changes:
In order to facilitate Finch on Windows, we need a root filesystem. We will use this Dockerfile as a basis for that root filesystem - using
docker exportto turn a built container into an archived rootfs. For the scope of these changes, create the Dockerfile and an action that runs on changes to the file to build and push to ECR repo.The Dockerfile will be used to create a container such that we can export that container's fs as a tarball and compress it for use with WSL2. For now, we are including cloud-init (at least for the WSL2 rootfs) but need further investigation to determine if we can remove the package to further slim the rootfs..
In order to create the container used as an intermediate step to export
its rootfs, we need to tell buildkit to load the image into Docker. See
This exposes a limitation of buildkit to load multiplatform images:
buildx failed with: ERROR: docker exporter does not currently support exporting manifest liststhus why the action runs two build-rootfs-image jobs - one for each arch.
See docker/buildx#59 and docker/roadmap#371
Additionally, network performance of the arm64 build is quite slow -
downloads of packages via dnf are on the scale of kb/s (but this has not
been observed on Ubuntu or Alpine images)
Testing done:
Local copy in a private repo,
actLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.