fix: make install.dependencies on Windows #340
Merged
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
fix-make-install-deps-on-windows-runner
branch
from
b5f8885
to
2b3f8c8
Compare
pendo324
reviewed
Jun 25, 2024
austinvazquez
force-pushed
the
fix-make-install-deps-on-windows-runner
branch
from
2b3f8c8
to
91e2c0f
Compare
pendo324
approved these changes
Jun 25, 2024
austinvazquez
force-pushed
the
fix-make-install-deps-on-windows-runner
branch
from
91e2c0f
to
20800e2
Compare
This change fixes make install.dependencies on Windows. The Windows platform relies on sha512sum tool instead of shasum tool which is available on macOS. This change also adds a spot check for make install.dependencies on macOS 13 and Windows to CI. Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-make-install-deps-on-windows-runner
branch
from
20800e2
to
90fe679
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Found during integration of 91c52d7 into finch.
Description of changes:
This change fixes make install.dependencies on Windows. The Windows
platform relies on sha512sum tool instead of shasum tool which is
available on macOS. This change also adds a spot check for make
install.dependencies on macOS 13 and Windows to CI.
Testing done:
make install.dependencies&&make cleanis successful on macOS 13 and Windows 2022License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.