feat: Add exit status code to finch #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
swagatbora90
previously approved these changes
Aug 20, 2024
pendo324
previously approved these changes
Aug 20, 2024
Signed-off-by: Shubharanshu Mahapatra <[email protected]>
Shubhranshu153
dismissed stale reviews from pendo324 and swagatbora90
via
25e264c
Shubhranshu153
force-pushed
the
feat-exit-status
branch
from
3cbbe7c
to
25e264c
Compare
swagatbora90
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
add exit status code to finch to return exit code if interface has exit codes.
Testing done:
shubhum@147ddaa42911 finch % finch run --rm alpine sh -c "exit 10"
shubhum@147ddaa42911 finch % echo $?
10
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.