Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset disks and force remove vm after suite execution #846

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

Shubhranshu153
Copy link
Contributor

@Shubhranshu153 Shubhranshu153 commented Mar 7, 2024

Issue #, if available:

*Description of changes: Force remove vm and clean disks. This gives a chance to recover from builkit failures caused by non-existent uuid files

Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just left a minor comment

e2e/vm/vm_windows_test.go Show resolved Hide resolved
@Shubhranshu153 Shubhranshu153 merged commit c2363b1 into runfinch:main Mar 11, 2024
22 checks passed
Shubhranshu153 pushed a commit that referenced this pull request Mar 29, 2024
🤖 I have created a release *beep* *boop*
---


## [1.1.3](v1.1.2...v1.1.3)
(2024-03-28)


### Build System or External Dependencies

* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.25.0 to 1.25.2
([#831](#831))
([9eb8097](9eb8097))
* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.25.2 to 1.25.3
([#856](#856))
([e9314f0](e9314f0))
* **deps:** Bump github.com/aws/aws-sdk-go-v2 from 1.25.3 to 1.26.0
([#864](#864))
([9223219](9223219))
* **deps:** Bump github.com/docker/cli from 25.0.3+incompatible to
25.0.4+incompatible
([#857](#857))
([838fc07](838fc07))
* **deps:** Bump github.com/docker/cli from 25.0.4+incompatible to
26.0.0+incompatible
([#867](#867))
([4167d3d](4167d3d))
* **deps:** Bump github.com/docker/docker from 25.0.3+incompatible to
25.0.4+incompatible
([#845](#845))
([769ae32](769ae32))
* **deps:** Bump github.com/docker/docker from 25.0.4+incompatible to
26.0.0+incompatible
([#866](#866))
([7fa6e72](7fa6e72))
* **deps:** Bump github.com/lima-vm/lima from 0.20.1 to 0.20.2
([#855](#855))
([99d4c3c](99d4c3c))
* **deps:** Bump github.com/lima-vm/lima from 0.20.2 to 0.21.0
([#862](#862))
([120ffcc](120ffcc))
* **deps:** Bump github.com/onsi/ginkgo/v2 from 2.15.0 to 2.16.0
([#842](#842))
([8e04421](8e04421))
* **deps:** Bump github.com/onsi/gomega from 1.31.1 to 1.32.0
([#860](#860))
([b2c9449](b2c9449))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.13 to 0.7.14
([#834](#834))
([2287575](2287575))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.24.1 to 3.24.2
([#838](#838))
([d2612aa](d2612aa))
* **deps:** Bump github.com/stretchr/testify from 1.8.4 to 1.9.0
([#839](#839))
([9f0953d](9f0953d))
* **deps:** Bump golang.org/x/crypto from 0.19.0 to 0.20.0
([#833](#833))
([1ed1474](1ed1474))
* **deps:** Bump golang.org/x/crypto from 0.20.0 to 0.21.0
([#843](#843))
([b7ef6f2](b7ef6f2))
* **deps:** Bump golang.org/x/tools from 0.18.0 to 0.19.0
([#844](#844))
([f8883b2](f8883b2))
* **deps:** Bump google.golang.org/protobuf from 1.32.0 to 1.33.0
([#858](#858))
([14532d5](14532d5))
* **deps:** Bump k8s.io/apimachinery from 0.29.2 to 0.29.3
([#863](#863))
([c8a4262](c8a4262))
* **deps:** Bump submodules and dependencies
([#825](#825))
([8828c56](8828c56))


### Bug Fixes

* parse management commands with proper arguments
([#876](#876))
([e2f42fe](e2f42fe))
* Reset disks and force remove vm after suite execution
([#846](#846))
([c2363b1](c2363b1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants