Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup / better naming #283

Open
YellowOnion opened this issue Dec 8, 2023 · 0 comments
Open

code cleanup / better naming #283

YellowOnion opened this issue Dec 8, 2023 · 0 comments

Comments

@YellowOnion
Copy link

Honestly some of the tests here are useless simply because there's name ambiguity.

There's comments in the code base about crc32c, but no tests are named crc32c, all are named crc32, there's are two different algorithms, they should not be using the same name.

There's about two tests, "aesnihash" and "aesni" very similar names, and because everything is just dumped in the main directory it's really hard to find the specific code for the specific implementation. just finding main.cpp is a mission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant