Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag_no_case panicks while matching certain unicode capitalized characters. #1719

Open
DelSkayn opened this issue Jan 3, 2024 · 0 comments
Open

Comments

@DelSkayn
Copy link

DelSkayn commented Jan 3, 2024

  • Rust version : 1.75.0
  • nom version : 7.1.3 and also main at the time of creating the issue.
  • nom compilation features used: default features only

Test case

fn main() {
    let _ = nom::bytes::complete::tag_no_case::<_,_,nom::error::Error<&str>>("k")("K");
}

The tag_no_case function can panic whenever a character in a to be matched string lowercases to a character with a shorter byte pattern.

In the above example the K to be matched is actually the kelvin sign with the UTF-8 byte pattern of 0xE2 0x84 0xAA. This character has a the normal single byte k as its lowercase character and therefore matches the tag.

The tag_no_case implementation, after matching a string to the tag, splits the given string with the length of the tag:

CompareResult::Ok => Ok((i.take_from(tag_len), OM::Output::bind(|| i.take(tag_len)))),

This assumes that the length in bytes of the matched characters is the same as the tag it was matched to. But, as in the above example, this is not always the case, resulting in the function sometimes trying to split a string outside of a character boundary and panicking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant