Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MSRV to 1.63 #959

Closed
jswrenn opened this issue Jun 17, 2024 · 5 comments · Fixed by #960
Closed

Increase MSRV to 1.63 #959

jswrenn opened this issue Jun 17, 2024 · 5 comments · Fixed by #960
Labels
breaking-change const-generics Require Rust 1.51 or newer

Comments

@jswrenn
Copy link
Member

jswrenn commented Jun 17, 2024

This will allow us to progress on const-generics Require Rust 1.51 or newer , particularly #560. This entails:

@jswrenn jswrenn added breaking-change const-generics Require Rust 1.51 or newer labels Jun 17, 2024
@Philippe-Cholet
Copy link
Member

Philippe-Cholet commented Jun 17, 2024

And update

//! This version of itertools requires Rust 1.43.1 or later.

@scottmcm
Copy link
Contributor

scottmcm commented Jun 17, 2024

👍 to 1.63 here. The more things can be from_fn instead of writing unsafe code here the better.

And anyone using 1.69 or greater -- probably nearly everyone, TBH -- will get a version with a bunch of internal optimizations to how map and from_fn work.

@Philippe-Cholet
Copy link
Member

@kinto-b That's something you might want to do.
The "big" part here is to grep clippy and see which lint(s) can be resolved, if any.

@kinto-b
Copy link
Contributor

kinto-b commented Jun 17, 2024

@Philippe-Cholet Sure thing :) I assume you mean, go through and see which #[allow(clippy::*)] can be dropped?

Shall I also action the TODOs such as

#[allow(deprecated)] //TODO: once msrv hits 1.51. replace `fold1` with `reduce`
iterable
.into_iter()
.fold1(|mut a, b| {
a.extend(b);
a
})
.unwrap_or_default()

@jswrenn
Copy link
Member Author

jswrenn commented Jun 17, 2024

Yes, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change const-generics Require Rust 1.51 or newer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants