Clarify C-DEREF #251
Open
Clarify C-DEREF #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ship has flown the nest; `Deref` is not exclusively for smart pointers anymore. Fixes rust-lang#249, the direct contradiction of C-DEREF with idiomatic std APIs.
|
This is weaker than some of the other proposals I've made for how we could reword C-DEREF and/or C-SMART-PTR in #249, but I think this is a small, reasonable, incremental improvement/clarification that should be fairly unobjectionable. |
CAD97
commented
Aug 25, 2021
| @@ -141,7 +141,7 @@ specifically to accommodate smart pointers, and so the traits should be used | |||
| with those rules in mind. | |||
|
|
|||
| As a general guideline, consider the "_as-a_" rule. If you implement `Deref`, | |||
| wherever `&Target` is acceptable, `&Self` works just as well as a `&Target`. | |||
| wherever `&Target` is acceptable, `&Self` works just as well as `&Target`. | |||
There was a problem hiding this comment.
I originally wanted to have a literal "as a" here, but I'd rather completely avoid the a/an question for &Type since this is still grammatically correct without the article, if not more correct (due to the lack of an article on &Self).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ship has flown the nest;
Derefis not exclusively for smart pointers anymore.Fixes #249, the direct contradiction of C-DEREF with idiomatic std APIs.