You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Chapter 9.2 on Recoverable Errors contains two code blocks that do not compile; however, Ferris the Crab is absent from them, and doesn't highlight the blocks in red.
Also, some parts contain code that is later shown to panic, but only under a condition. Should those also be specified with the panics tag alongside?
I don't think so.
The panics tag is (in my opinion) intended for examples when the code always panics and the fact that it panics is incorrect (e.g. ch03-02#invalid-array-element-access).
The parts you are referring to are, on the other hand, possibly correct (depending on your specific case it might be more idiomatic to use Result and friends, but that is the topic of ch09-03-to-panic-or-not-to-panic), e.g. they panic only when the file in question is not found.
The parts you are referring to are, on the other hand, possibly correct (depending on your specific case it might be more idiomatic to use Result and friends, but that is the topic of ch09-03-to-panic-or-not-to-panic), e.g. they panic only when the file in question is not found.
Chapter 9.2 on Recoverable Errors contains two code blocks that do not compile; however, Ferris the Crab is absent from them, and doesn't highlight the blocks in red.
Simply marking the blocks with additional
does_not_compile
should suffice.Also, some parts contain code that is later shown to panic, but only under a condition. Should those also be specified with the
panics
tag alongside?CC: @u32i64 (committed extensively regarding Ferris)
The text was updated successfully, but these errors were encountered: