Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drafts to get into beta #614

Closed
11 of 16 tasks
carols10cents opened this issue Apr 10, 2017 · 9 comments
Closed
11 of 16 tasks

Drafts to get into beta #614

carols10cents opened this issue Apr 10, 2017 · 9 comments

Comments

@carols10cents
Copy link
Member

carols10cents commented Apr 10, 2017

chapter 18

chapter 19

chapter 20

other

@steveklabnik
Copy link
Member

@carols10cents i pushed 19.5; I dropped move closures since they were discussed before. We should figure out what we want with them overall, but I think for the purposes of this ticket, it's not a big deal.

@carols10cents
Copy link
Member Author

@steveklabnik i got through the end of fully qualified syntax today, i gtg for now. I know tomorrow is Meeting Day, but if you find yourself with time in between, feel free to start reviewing my edits from the start of ch 19 and I'll see if I can keep ahead of you.... there are some TODOs I put in there where I'm really not sure of what I'm doing. Especially check the Lifetime Subtyping section, I was kind of lost so make sure I didn't make up an untrue story that makes more sense in my head than what actually happens while trying to clear it up....

@steveklabnik
Copy link
Member

Yeah, even though it is, I really want to make sure I stay ahead of you here. ❤️

@steveklabnik
Copy link
Member

Subtyping section looks good to me 😄

I pushed ab1b71f to fix the FIXMEs, what do you think?

@steveklabnik
Copy link
Member

@carols10cents

theme

is what i have regarding the beta link; WDYT? It's very.... basic

@carols10cents
Copy link
Member Author

it's kinda.... scary? idk. maybe something just as saturated but not aaaaa error red? i feel like most any color would still stand out since everything else is b&w... unless you were going for scary :)

@steveklabnik
Copy link
Member

I wasn't going for anything; I'm just real bad at visuals, heh

@steveklabnik
Copy link
Member

Okay i did some stuff e8a9c6b

draft

(yay twitter bootstrap)

@steveklabnik
Copy link
Member

steveklabnik commented Apr 17, 2017

re: put an image of the cover on https://doc.rust-lang.org/nightly/book/ ? I've sent an email to no starch to triple check that this is okay with them

Update: this is blocked on stuff; we may or may not be able to get it into beta, can always backport later though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants