Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce report, even if no CI builds are found #124

Open
aDotInTheVoid opened this issue Dec 27, 2020 · 1 comment
Open

Produce report, even if no CI builds are found #124

aDotInTheVoid opened this issue Dec 27, 2020 · 1 comment
Labels
A-errors Area: errors and warnings help wanted Extra attention is needed

Comments

@aDotInTheVoid
Copy link
Member

Currently, if their are no ci builds, a report isn't printed as here an error is returned

cargo-bisect-rustc/src/main.rs

Lines 1146 to 1152 in 37e4366

if commits.is_empty() {
bail!(
"no CI builds available between {} and {} within last 167 days",
start,
end
);
}

so this function exits early

let ci_bisection_result =
bisect_ci_via(cfg, client, &*cfg.repo_access, &working_commit, &bad_commit)?;
print_results(cfg, client, &ci_bisection_result);
print_final_report(cfg, &nightly_bisection_result, &ci_bisection_result);

It would be nice to show a report, even if their are no CI builds availible

@savente93
Copy link
Contributor

Am having a look at this. Would it be acceptable to just print the results that are there or is more work needed? (i.e. if there is no CI builds available, just print the nightly bisection report and not the rest)

@ehuss ehuss added help wanted Extra attention is needed A-errors Area: errors and warnings labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-errors Area: errors and warnings help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants